[PATCH 6/7] input: pmic8xxx-pwrkey: Pass correct pointer to free_irq()

From: Lars-Peter Clausen
Date: Mon May 20 2013 - 10:52:53 EST

free_irq() expects the same pointer that was passed to request_irq(), otherwise
the IRQ is not freed.

The issue was found using the following coccinelle script:

type T;
T devid;
request_irq(..., devid)

type r1.T;
T devid;
position p;
free_irq@p(..., devid)

position p != r2.p;

Cc: Trilok Soni <tsoni@xxxxxxxxxxxxxx>
Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
drivers/input/misc/pmic8xxx-pwrkey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/misc/pmic8xxx-pwrkey.c b/drivers/input/misc/pmic8xxx-pwrkey.c
index afd0af9..b49b738 100644
--- a/drivers/input/misc/pmic8xxx-pwrkey.c
+++ b/drivers/input/misc/pmic8xxx-pwrkey.c
@@ -175,7 +175,7 @@ static int pmic8xxx_pwrkey_probe(struct platform_device *pdev)
return 0;

- free_irq(key_press_irq, NULL);
+ free_irq(key_press_irq, pwrkey);
pwr = NULL;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/