Re: [PATCH net-next] net: netdev_pick_tx: use get_xps_q if xps mapis set

From: Eric Dumazet
Date: Fri May 17 2013 - 18:03:30 EST

On Sat, 2013-05-18 at 01:20 +0530, govind wrote:

> I see. In ixgbe_select_queue we use __netdev_pick_tx only if packet is not
> If you see
> bnx2x_select_queue in drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c, line 1832
> and mlx4_en_select_queue in drivers/net/ethernet/mellanox/mlx4/en_tx.c, line 547.
> we cannot have xps working with these drivers.
> This needs to be fixed by replacing __skb_tx_hash with __netdev_pick_tx. Am i
> correct?

Yes, this seems better.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at