Re: [PATCH 1/1] posix-timers: Show clock ID in proc file

[Greg KH]

On Fri, May 17, 2013 at 08:12:55PM +0400, Pavel Emelyanov wrote:
> On 05/17/2013 07:59 PM, Greg KH wrote:
> > On Fri, May 17, 2013 at 02:12:03AM +0400, Pavel Tikhomirov wrote:
> >> Expand information about posix-timers in /proc/<pid>/timers by adding
> >> info about clock, with which the timer was created. I.e. in the forth
> >> line of timer info after "notify:" line go "ClockID: <clock_id>".
> >>
> >> Signed-off-by: Pavel Tikhomirov <snorcht@xxxxxxxxx>
> >> ---
> >>  fs/proc/base.c |    1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/fs/proc/base.c b/fs/proc/base.c
> >> index 2dad4a9..8a38eef 100644
> >> --- a/fs/proc/base.c
> >> +++ b/fs/proc/base.c
> >> @@ -2079,6 +2079,7 @@ static int show_timer(struct seq_file *m, void *v)
> >>  		nstr[notify & ~SIGEV_THREAD_ID],
> >>  		(notify & SIGEV_THREAD_ID) ? "tid" : "pid",
> >>  		pid_nr_ns(timer->it_pid, tp->ns));
> >> +	seq_printf(m, "ClockID: %d\n", timer->it_clock);
> > 
> > What userspace tool just broke by adding a new field to this file?
> 
> Zero for two reasons:
> 
> 1. this proc file appeared this merge window
> 2. this file format is
> 
>   <name>: <value>
> 
> and should be parsed line-by-line by applications like e.g. /proc/pid/status
> or /proc/pid/smaps. Both these files were extended with fields in the past with
> no worries to tools, so should be this new one.

Ok, just making sure :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/