RE: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driverSPI

[Mathias LEBLANC]

Hi Peter, 

Thanks for this new function.
I had already changed the for loop but i would to be sure that it's the best way and that you expected.

Don't hesitate if you have any other recommendation or any comments for this driver.

Regards,

Mathias Leblanc
________________________________________
From: Peter Hüwe [PeterHuewe@xxxxxx]
Sent: 16 May 2013 21:03
To: tpmdd-devel@xxxxxxxxxxxxxxxxxxxxx
Cc: Mathias LEBLANC; Jean-Luc BLANC; linux-kernel@xxxxxxxxxxxxxxx; Rajiv Andrade; Sirrix AG
Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

Hi Matthias:

> Regarding the while loop, I don't see how can I check the number of dummy
> byte differently?


Checking the number of dummy bytes is fine -
in line #144 you check it with a while loop which looks fine
in line #198 you check it with a for loop with an empty body, which in my
opinion looks less nice than the while in #144.

So simply replace the second instance in #198 and I'm happy with that part ;)

Maybe also have a look at memchr_inv

/**
 * memchr_inv - Find an unmatching character in an area of memory.
 * @start: The memory area
 * @c: Find a character other than c
 * @bytes: The size of the area.
 *
 * returns the address of the first character other than @c, or %NULL
 * if the whole buffer contains just @c.
 */
void *memchr_inv(const void *start, int c, size_t bytes)



so #198 would look something like:
nbr_dummy_bytes = memchr_inv (xfer.rx_buf+nbr_dummy_bytes,
                                        0,
                                         total_length-nbr_dummy_bytes) - xfer.rx_buf;

But I'm not sure whether that's more readable, maybe give it a try.
 I'm also fine with the while loop.


Peter






--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/