Re: [PATCH 2/5] net: davinci_emac: remove unwanted header inclusionand sort the alphabetically

From: Prabhakar Lad
Date: Fri May 17 2013 - 00:53:40 EST

Hi Sergei,

Thanks for the review.

On Fri, May 17, 2013 at 12:25 AM, Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> On 16-05-2013 11:30, Lad Prabhakar wrote:
>> From: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
>> This patch removes unwanted header inclusion
> Why are they unwanted?
The driver builds without this includes.

This is arguable, if I would have added a new driver with the only
#includes which were required to build thats accepted. But when I remove
unnecessary #includes from the existing drivers that's not acceptable ?

This applies to rest of the similar patches in the series.

>> and sorts them alphabetically
> In the subject you typed "the" instead of "them".
Hmm carry forwarded this copy paste error every where will fix it in V2.

--Prabhakar Lad
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at