Re: [PATCH 1/2] pinctrl: samsung: fix suspend/resume functionality

From: Doug Anderson
Date: Thu May 16 2013 - 19:55:38 EST


Tomasz,

On Thu, May 16, 2013 at 4:10 PM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> If state of these registers isn't lost on those SoCs then running the
> save/restore shouldn't _hurt_ though, right? If you can run the old
> GPIO code on one of those systems and do a suspend/resume you could
> check...

I think it's been too long of a day for me, too.

I just thought about this and realized that there is no "powerdown"
registers for the GPX banks on exynos5250. ...and they don't lose
their state at sleep! ...so maybe a reasonable thing to do would be
to skip save/restore in any case where there are no powerdown
registers?

You can see a printout in my case:

[ 412.840000] gpx0 @ f004ac00 (con 0x30000110 => 0x30000110)
[ 412.840000] gpx1 @ f004ac20 (con 0x1f10ff10 => 0x1f10ff10)
[ 412.840000] gpx2 @ f004ac40 (con 0x1f000f0f => 0x1f000f0f)
[ 412.840000] gpx3 @ f004ac60 (con 0x00f00f01 => 0x00f00f01)

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/