Re: [PATCH v3 3/4] memory_hotplug: use pgdat_resize_lock() inonline_pages()

From: David Rientjes
Date: Thu May 16 2013 - 17:05:16 EST


On Wed, 15 May 2013, Andrew Morton wrote:

> On Mon, 13 May 2013 16:13:06 -0700 Cody P Schafer <cody@xxxxxxxxxxxxxxxxxx> wrote:
>
> > mmzone.h documents node_size_lock (which pgdat_resize_lock() locks) as
> > follows:
> >
> > * Must be held any time you expect node_start_pfn, node_present_pages
> > * or node_spanned_pages stay constant. [...]
>
> Yeah, I suppose so. Although no present code sites actually do that.
>

Agreed, I see no purpose in patches 2-4 in this series as mentioned in v2.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/