Re: [PATCH 1/5] davinci: net: cpdma: remove unwanted header fileincusion and sort thme alphabetically

From: Sergei Shtylyov
Date: Thu May 16 2013 - 14:53:23 EST


Hello.

On 16-05-2013 11:30, Lad Prabhakar wrote:

s/incusion/inclusion/, s/thme/them/ in the subject. Though instead of "them" it would be better to write "headers".

From: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>

Changelog won't hurt here... which unwanted #include's you are removing and why are they unwanted?

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
---
drivers/net/ethernet/ti/davinci_cpdma.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
index 49dfd59..f7ce97f 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.c
+++ b/drivers/net/ethernet/ti/davinci_cpdma.c
@@ -12,15 +12,11 @@
* of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
-#include <linux/kernel.h>
-#include <linux/spinlock.h>
-#include <linux/device.h>
+
+#include <linux/delay.h>
+#include <linux/dma-mapping.h>
#include <linux/module.h>
#include <linux/slab.h>
-#include <linux/err.h>
-#include <linux/dma-mapping.h>
-#include <linux/io.h>
-#include <linux/delay.h>

#include "davinci_cpdma.h"

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/