Re: Drop WARN on AMD lack of perfctrs

From: Peter Zijlstra
Date: Thu May 16 2013 - 14:12:11 EST


On Thu, May 16, 2013 at 01:55:57PM -0400, Josh Boyer wrote:
> Maybe. But do you really need to dump a stack trace here? What is a
> user supposed to do with that information? Can they fix the kernel?
> Can the fix the CPU? As far as I can tell, they can't do either.

Send their CPU back to AMD is I suppose the best they can do ;-)

> Is using pr_err with the same message really somehow worse than using
> WARN?

I would make it a FW_BUG as well. But yeah, I suppose that is a better option
than the WARN_ON. Unless Robert had a different reason...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/