Re: [PATCH 1/1] usermodehelper: check subprocess_info->path != NULL

[Lucas De Marchi]

Hi Oleg,

On Thu, May 16, 2013 at 12:43 PM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> argv_split(empty_or_all_spaces) happily succeeds, it simply returns
> argc == 0 and argv[0] == NULL. Change call_usermodehelper_exec() to
> check sub_info->path != NULL to avoid the crash.
>
> This is the minimal fix, todo:
>
>         - perhaps we should change argv_split() to return NULL or
>           change the callers.

Changing argv_split() would be the easiest way, but then we can't
differentiate the errors. Right now it returns NULL only on ENOMEM.


>
>         - kill or justify ->path[0] check

I'm not sure about this, it's already there before my refactor and I
don't think it makes any good. From modprobe pespective, I'd say it
would be better to give an error than say everything went ok.


>
>         - narrow the scope of helper_lock()
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> ---
>  kernel/kmod.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/kmod.c b/kernel/kmod.c
> index 1296e72..8241906 100644
> --- a/kernel/kmod.c
> +++ b/kernel/kmod.c
> @@ -569,6 +569,11 @@ int call_usermodehelper_exec(struct subprocess_info *sub_info, int wait)
>         int retval = 0;
>
>         helper_lock();
> +       if (!sub_info->path) {
> +               retval = -EINVAL;
> +               goto out;
> +       }
> +
>         if (sub_info->path[0] == '\0')
>                 goto out;
>
> --

Acked-By: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>


Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/