Re: [PATCH v2] regulator: lp872x: support the device tree feature

From: Mark Brown
Date: Thu May 16 2013 - 11:47:41 EST

On Fri, May 10, 2013 at 07:17:48AM +0000, Kim, Milo wrote:

> Patch v2.
> Move the opmode code of the device tree from 'of_regulator' to the lp872x
> because its mode depends on the device.
> Supported modes in LP8720/5 are 'fast' and 'normal'.

> Patch v1.
> Initial patch

Please keep these changelogs after the --- so they don't get included in
the final changelog by git am.

> +Optional properties:
> +- general-config: the value of LP872X_GENERAL_CFG register (u8)
> +- update-config: define it when LP872X_GENERAL_CFG register should be updated

A bit more information on this one wouldn't hurt but the information
will be in the datasheet I guess.

> +- dvs-gpio: GPIO number for DVS control

If this is the AP side GPIO then it ought to be a standard GPIO
specifier rather than a GPIO number. If this is the pin on the PMIC
then it probably ought to be spelled out a bit more clearly.

> +- dvs-vsel: DVS selector. 0 = SEL_V1, 1 = SEL_V2.
> +- dvs-state: initial DVS pin state. 0 = DVS_LOG, 1 = DVS_HIGH.

Any custom properties are supposed to be namespaced, for example

> +Child node
> +- regulator-id: the value of enum lp872x_regulator_id. (u8)

These would need to be listed as part of the binding, though it'd be
much more friendly to use plain text names and of_regulator_match() to
look them up. That makes the binding much more legible.

Attachment: signature.asc
Description: Digital signature