Re: [PATCH 21/33] drivers/usb/chipidea: don't check resource with devm_ioremap_resource

From: Alexander Shishkin
Date: Thu May 16 2013 - 07:29:26 EST


Wolfram Sang <wsa@xxxxxxxxxxxxx> writes:

> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>

Acked-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>

> ---
> drivers/usb/chipidea/core.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 450107e..49b098b 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -370,11 +370,6 @@ static int ci_hdrc_probe(struct platform_device *pdev)
> }
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "missing resource\n");
> - return -ENODEV;
> - }
> -
> base = devm_ioremap_resource(dev, res);
> if (IS_ERR(base))
> return PTR_ERR(base);
> --
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/