Re: [PATCH] ASoC: max98090: add digital mic mux to record path

From: Andrew Bresticker
Date: Thu May 16 2013 - 02:43:14 EST

Hi Matthew,

> Default Routing:
> Of note (software can confirm) I believe the default DAPM routing for the
> driver was intentional setup such that :
> Record:
> o If a headset MIC is present, record from it.
> o If not, digital MIC is the default record input.

While this may have been the intention, that's not what the driver is
currently doing. This is how the capture route looks before this

HiFi Capture -> AIFOUT{L,R} -> LBEN{L,R}_MUX[0] -> DMIC{L,R}_ENA

So, since DMIC{L,R}_ENA are configured as supplies, they will always
be turned on during record when the loopback mux is set to 0 (i.e. no
loopback) That's obviously wrong, so this patch changes the
DMIC{L,R}_ENA to muxes.

> The defaults can be modified by each end user as needed (for analog
> microphones, line inputs, etc.). Please insure any patch to the baseline
> driver reflects the correct operation of the digital microphone enable bits,
> and preserves the intended default operation.

Ok, I'll change it so that the DMIC{L,R} muxes aren't individually controllable.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at