Re: [PATCH] serial: pl011: protect attribute read from NULL platformdata struct

From: Lee Jones
Date: Wed May 15 2013 - 05:23:32 EST


On Mon, 13 May 2013, Linus Walleij wrote:

> On Thu, May 9, 2013 at 2:50 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> > It's completely feasible that platform data will be empty i.e. when
> > booting with Device Tree with no device AUXDATA. So we must protect
> > it's use in these use-cases, or risk a kernel Oops.
> >
> > Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Cc: Jiri Slaby <jslaby@xxxxxxx>
> > Cc: linux-serial@xxxxxxxxxxxxxxx
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > ---
> > ******* *******
> > If this issue has not already been fixed, this patch should be applied
> > during the v3.10 -rc:s, as it fixes a serious bug which was introduced
> > in the merge-window.
> > ******* *******
>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> You should probably put Greg on To: so that he picks this up for
> the -rc:s ASAP.

I spoke with Greg yesterday. He's catching up on mail.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/