Re: [RFC PATCH v2, part 2 12/18] PCI, ACPI: use hotplug-safe iterators to walk PCI buses

From: Rafael J. Wysocki
Date: Tue May 14 2013 - 16:19:48 EST


On Wednesday, May 15, 2013 12:51:56 AM Jiang Liu wrote:
> Enhance ACPI reset drvier to use hotplug-safe iterators to walk PCI buses.
>
> Signed-off-by: Jiang Liu <jiang.liu@xxxxxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rjw@xxxxxxx>
> Cc: linux-acpi@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

> ---
> drivers/acpi/reboot.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/reboot.c b/drivers/acpi/reboot.c
> index a6c77e8b..532dd6d 100644
> --- a/drivers/acpi/reboot.c
> +++ b/drivers/acpi/reboot.c
> @@ -33,7 +33,7 @@ void acpi_reboot(void)
> switch (rr->space_id) {
> case ACPI_ADR_SPACE_PCI_CONFIG:
> /* The reset register can only live on bus 0. */
> - bus0 = pci_find_bus(0, 0);
> + bus0 = pci_get_bus(0, 0);
> if (!bus0)
> return;
> /* Form PCI device/function pair. */
> @@ -43,6 +43,7 @@ void acpi_reboot(void)
> /* Write the value that resets us. */
> pci_bus_write_config_byte(bus0, devfn,
> (rr->address & 0xffff), reset_value);
> + pci_bus_put(bus0);
> break;
>
> case ACPI_ADR_SPACE_SYSTEM_MEMORY:
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/