Re: [PATCH 4/4] staging: ste_rmi4: Suppress 'ignoring return value of âregulator_enable()' warning

From: Lee Jones
Date: Tue May 14 2013 - 06:46:41 EST


Hi Greg,

> drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:
> In function âsynaptics_rmi4_resumeâ:
> drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18:
> warning: ignoring return value of âregulator_enableâ, declared
> with attribute warn_unused_result [-Wunused-result
>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: devel@xxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
> index fe667dd..c4d013d 100644
> --- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
> +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
> @@ -1087,7 +1087,9 @@ static int synaptics_rmi4_resume(struct device *dev)
> unsigned char intr_status;
> struct synaptics_rmi4_data *rmi4_data = dev_get_drvdata(dev);
>
> - regulator_enable(rmi4_data->regulator);
> + retval = regulator_enable(rmi4_data->regulator);
> + if (retval < 0)
> + return retval;
>
> enable_irq(rmi4_data->i2c_client->irq);
> rmi4_data->touch_stopped = false;

Are you planning to take this into the v3.10 -rcs?

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/