Re: [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs_error()

From: Gu Zheng
Date: Mon May 13 2013 - 23:18:29 EST


On 05/13/2013 05:28 PM, OGAWA Hirofumi wrote:

> Gu Zheng <guz.fnst@xxxxxxxxxxxxxx> writes:
>
>> >From 87141ec058aad35ac55bc7c3fc2eb378566a5a6a Mon Sep 17 00:00:00 2001
>> From: Gu Zheng <guz.fnst@xxxxxxxxxxxxxx>
>> Date: Mon, 13 May 2013 17:48:19 +0900
>> Subject: [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs_error()
>
>> - printk(KERN_ERR "FAT-fs (%s): error, %pV\n", sb->s_id, &vaf);
>> + fat_msg(sb, KERN_ERR, "error, %pV", &vaf);
>> va_end(args);
>
> I'm assuming nested "%pV" is works fine. If so,

It works fine, I've tested this.

>
> Acked-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>

Thanks!

Best regards,
Gu

>
>> @@ -38,8 +38,7 @@ void __fat_fs_error(struct super_block *sb, int report, const char *fmt, ...)
>> panic("FAT-fs (%s): fs panic from previous error\n", sb->s_id);
>> else if (opts->errors == FAT_ERRORS_RO && !(sb->s_flags & MS_RDONLY)) {
>> sb->s_flags |= MS_RDONLY;
>> - printk(KERN_ERR "FAT-fs (%s): Filesystem has been "
>> - "set read-only\n", sb->s_id);
>> + fat_msg(sb, KERN_ERR, "Filesystem has been set read-only");
>> }
>> }
>> EXPORT_SYMBOL_GPL(__fat_fs_error);
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/