[RFC PATCH 0/2] return value from shrinkers

From: Oskar Andero
Date: Mon May 13 2013 - 10:16:54 EST


Hi,

In a previous discussion on lkml it was noted that the shrinkers use the
magic value "-1" to signal that something went wrong.

This patch-set implements the suggestion of instead using errno.h values
to return something more meaningful.

The first patch simply changes the check from -1 to any negative value and
updates the comment accordingly.

The second patch updates the shrinkers to return an errno.h value instead
of -1. Since this one spans over many different areas I need input on what is
a meaningful return value. Right now I used -EBUSY on everything for consitency.

What do you say? Is this a good idea or does it make no sense at all?

Thanks!

-Oskar

Oskar Andero (2):
mm: vmscan: let any negative return value from shrinker mean error
Clean-up shrinker return values

drivers/staging/android/ashmem.c | 2 +-
drivers/staging/zcache/zcache-main.c | 2 +-
fs/gfs2/glock.c | 2 +-
fs/gfs2/quota.c | 2 +-
fs/nfs/dir.c | 2 +-
fs/ubifs/shrinker.c | 2 +-
include/linux/shrinker.h | 5 +++--
mm/vmscan.c | 2 +-
net/sunrpc/auth.c | 2 +-
9 files changed, 11 insertions(+), 10 deletions(-)

--
1.8.1.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/