Re: Build regressions/improvements in v3.10-rc1 (avr)

From: Geert Uytterhoeven
Date: Mon May 13 2013 - 09:00:54 EST


On Mon, May 13, 2013 at 2:54 PM, Hans-Christian Egtvedt
<egtvedt@xxxxxxxxxxxx> wrote:
> Around Sun 12 May 2013 22:45:01 +0200 or thereabout, Geert Uytterhoeven wrote:
>> On Sun, 12 May 2013, Geert Uytterhoeven wrote:
>>> However, the full list of errors isn't that unmanageable, so I'm following
>>> up with a digested list...
>>
>> (.init.text+0x540): undefined reference to `atmel_default_console_device': 1 errors in 1 logs
>> v3.10-rc1/avr32/avr32-allnoconfig
>> Patch sent last February
>
> I recall to have acked patch(es) related to the serial (console) driver.

Sure, but so far arch/avr doesn't fall under my jurisdiction, so I
haven't sent it
upstream yet ;-)

Anyway, it seems I have accumulated too many patches for exotic
arches, so I plan
to create an exotic-arch-fixes branch, to be pulled by Linus in a few rcs...

> It is caused by CONFIG_SERIAL_ATMEL no set in .config, but the machine code
> still writes to atmel_default_console_device when you call
> at32_setup_serial_console().
>
> Two ways to fix, either select the SERIAL_ATMEL symbol or ifdef around the
> atmel_default_console_device assignment in the machine code.

Yep, my patch did the latter.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/