Re: EXT4 panic at jbd2_journal_put_journal_head() in 3.9+

[Theodore Ts'o]

On Sun, May 12, 2013 at 08:11:59PM -0700, Tony Luck wrote:
> 
> My best guess as to why this commit causes problems is that there are places
> where updates to individual fields in this structure used to be independent
> because they were to whole words.  Now we have bitfileds there are races
> between access to different fields in the same word.

Yeah, except we access the fields while holding a lock.... wait a
minute.  We're using bit_spinlocks().... and am I missing something?

Where are the barrier statements to prevent the CPU or the compiler
from reordering statements around bit_spin_lock()?  But if that's the
problem, I would have expected lots of other things to be broken.

	   	      	       	       	     - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/