Re: [PATCH V2 2/3] Documentation: virtio: Add emergency write (emerg_wr) config register in virtio console.

From: Rusty Russell
Date: Sun May 12 2013 - 22:58:32 EST


Rob Landley <rob@xxxxxxxxxxx> writes:
> On 05/06/2013 07:19:50 AM, Pranavkumar Sawargaonkar wrote:
>> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@xxxxxxxxxx>
>> Signed-off-by: Anup Patel <anup.patel@xxxxxxxxxx>
>> ---
>> Documentation/virtual/virtio-spec.txt | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/virtual/virtio-spec.txt
>> b/Documentation/virtual/virtio-spec.txt
>> index 0d6ec85..3ca38f8 100644
>> --- a/Documentation/virtual/virtio-spec.txt
>> +++ b/Documentation/virtual/virtio-spec.txt
>> @@ -1927,11 +1927,16 @@ Ports 2 onwards only if
>> VIRTIO_CONSOLE_F_MULTIPORT is set
>> ports; configuration fields nr_ports and max_nr_ports are
>> valid and control virtqueues will be used.
>>
>> + VIRTIO_CONSOLE_F_EMERG_WRITE(2) Device has support for emergency
>> + write. Configuration filed emerg_wr is valid.
>
> Emergency?
>
> Really?
>
> Out of morbid curiosity, what would constitute an _emergency_ in a
> virtual machine logging context?

Usually, your console device is broken. Or you can't set it up because
you can't allocate memory. Or you oops before it is configured.

Terminology is a tricky thing, but the nuance here is that you don't
want to use this as your main console. It may not do anything. It may
drop characters. It's definitely slow.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/