Re: [PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource()

From: Laurent Navet
Date: Sun May 12 2013 - 11:53:19 EST


Please, don't take this one

I'll send a more complete one later,
Sorry,

2013/5/12, Laurent Navet <laurent.navet@xxxxxxxxx>:
> Replace a call to deprecated devm_request_and_ioremap by
> devm_ioremap_resource.
>
> Found with coccicheck and this semantic patch:
> scripts/coccinelle/api/devm_ioremap_resource.cocci
>
> Signed-off-by: Laurent Navet <laurent.navet@xxxxxxxxx>
> ---
> drivers/net/ethernet/broadcom/bcm63xx_enet.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> index 0b3e23e..9de4217 100644
> --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> @@ -1641,9 +1641,9 @@ static int bcm_enet_probe(struct platform_device
> *pdev)
> if (ret)
> goto out;
>
> - priv->base = devm_request_and_ioremap(&pdev->dev, res_mem);
> - if (priv->base == NULL) {
> - ret = -ENOMEM;
> + priv->base = devm_ioremap_resource(&pdev->dev, res_mem);
> + if (IS_ERR(priv->base)) {
> + ret = PTR_ERR(priv->base);
> goto out;
> }
>
> --
> 1.7.10.4
>
>


--
 On ne rÃsout pas un problÃme avec les modes de pensÃe qui lâont engendrÃ. Â
 You cannot solve current problems with current thinking. Current
problems are the result of current thinking Â
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/