Re: [PATCH 3/3] init/Kconfig: Add option to set modprobe command

From: Lucas De Marchi
Date: Fri May 10 2013 - 09:16:01 EST


On Fri, May 10, 2013 at 9:58 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> On 05/10, Lucas De Marchi wrote:
> >
> > -char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe -q --";
> > +char modprobe_path[KMOD_PATH_LEN] = CONFIG_DEFAULT_MODULE_LOAD_BIN;
>
> But even after 1/3 and 2/3 this can break free_modprobe_argv() ?
> It assumes that argv[3] is module_name.

Oh, right. Forgot about that. And this patch set should have been sent
as RFC, since I'm interested in feedback about the idea. What do you
think?



thanks

Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/