[Patch] block: do not leak info to user-space

From: Cong Wang
Date: Fri May 10 2013 - 05:06:55 EST


From: Cong Wang <amwang@xxxxxxxxxx>

There is a hole in struct hd_geometry, so we have to
zero the struct on stack before copying it to user-space.

Cc: Jens Axboe <axboe@xxxxxxxxx>
Signed-off-by: Cong Wang <amwang@xxxxxxxxxx>

---
diff --git a/block/compat_ioctl.c b/block/compat_ioctl.c
index 7c668c8..7e5d474 100644
--- a/block/compat_ioctl.c
+++ b/block/compat_ioctl.c
@@ -59,6 +59,7 @@ static int compat_hdio_getgeo(struct gendisk *disk, struct block_device *bdev,
if (!disk->fops->getgeo)
return -ENOTTY;

+ memset(&geo, 0, sizeof(geo));
/*
* We need to set the startsect first, the driver may
* want to override it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/