Re: [PATCH 08/12] net/ethernet: MACB should depend on HAS_DMA

[Nicolas Ferre]

On 09/05/2013 23:04, Geert Uytterhoeven :
> If NO_DMA=y:
>
> drivers/built-in.o: In function `macb_free_consistent':
> drivers/net/ethernet/cadence/macb.c:878: undefined reference to `dma_free_coherent'
> drivers/net/ethernet/cadence/macb.c:883: undefined reference to `dma_free_coherent'
> drivers/net/ethernet/cadence/macb.c:888: undefined reference to `dma_free_coherent'
> drivers/built-in.o: In function `macb_alloc_consistent':
> drivers/net/ethernet/cadence/macb.c:905: undefined reference to `dma_alloc_coherent'
> drivers/built-in.o: In function `macb_tx_interrupt':
> drivers/net/ethernet/cadence/macb.c:515: undefined reference to `dma_unmap_single'
> drivers/built-in.o: In function `macb_tx_error_task':
> drivers/net/ethernet/cadence/macb.c:457: undefined reference to `dma_unmap_single'
> drivers/built-in.o: In function `macb_start_xmit':
> drivers/net/ethernet/cadence/macb.c:838: undefined reference to `dma_map_single'
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>

Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>

> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx
> ---
>   drivers/net/ethernet/cadence/Kconfig |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
> index 0d9d6e6..768285e 100644
> --- a/drivers/net/ethernet/cadence/Kconfig
> +++ b/drivers/net/ethernet/cadence/Kconfig
> @@ -31,6 +31,7 @@ config ARM_AT91_ETHER
>
>   config MACB
>   	tristate "Cadence MACB/GEM support"
> +	depends on HAS_DMA
>   	select PHYLIB
>   	---help---
>   	  The Cadence MACB ethernet interface is found on many Atmel AT32 and


--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/