Re: [ 22/42] sched/debug: Fix sd->*_idx limit range avoiding overflow

From: Ingo Molnar
Date: Fri May 10 2013 - 03:59:51 EST



* Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:

> On Tue, 2013-04-23 at 14:52 -0700, Greg Kroah-Hartman wrote:
> > 3.8-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: libin <huawei.libin@xxxxxxxxxx>
> >
> > commit fd9b86d37a600488dbd80fe60cca46b822bff1cd upstream.
> >
> > Commit 201c373e8e ("sched/debug: Limit sd->*_idx range on
> > sysctl") was an incomplete bug fix.
> [...]
>
> It seems like both these commits ought to be applied to earlier stable
> branches. Or was the lack of range checking a regression after 3.4?

Both should be applied indeed.

They are not a huge problem as all these facilities are for debugging and
are root-only, but the two fixes should be applied together or not at all.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/