Re: [PATCH] perf: detect when perf.data file not closed out properly

[David Ahern]

On 5/9/13 3:32 AM, Ingo Molnar wrote:
> * David Ahern <dsahern@xxxxxxxxx> wrote:
>
> > +		pr_err("data size is 0. "
> > +		       "Was the record command properly terminated?\n");
>
> Btw., a small stylistic request: please put user-visible strings into a
> single line - even if it technically turns into an overlong line.
>
> 		pr_err("data size is 0. Was the record command properly terminated?\n");
>
> This 1) makes it easier for people to git grep the error text they are
> seeing during usage 2) makes it easier for _developers_ to see the
> messages they are outputing to users.

Totally agree just battling the line length.

> For example from the single-line output it's immediately visible that it
> should be capitalized thusly:
>
> 		pr_err("Data size is 0. Was the record command properly terminated?\n");

Ok. Will re-send later today.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/