Re: [PATCH] x86: make stat/statfs 64-bit for x86_64 kernels

From: Mike Frysinger
Date: Thu May 09 2013 - 00:08:47 EST


On Thursday 09 May 2013 00:04:03 H. Peter Anvin wrote:
> On 05/08/2013 09:00 PM, Mike Frysinger wrote:
> > When including these headers in the x32 ABI, the structs get declared
> > with 32bit sizes which is incorrect. Use long long and such to make
> > it work both with x32 and x86_64.
>
> I'm not sure if it is okay to change the types, even within the same
> size. Perhaps use __u64/__s64?

sorry, i don't follow. changing types isn't ok (unsigned long to unsigned
long long), but changing to __u64 is ok (unsigned long to __u64 which is
typedefed to unsigned long long) ?

i don't have a problem using __u64/__s64, i just don't understand your logic.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.