Re: [PATCH 0/3] firmware: Fix usermodehelper deadlock at shutdown

From: Ming Lei
Date: Wed May 08 2013 - 12:07:28 EST


Hi Takashi,

Sorry for not CC list.

On Wed, May 8, 2013 at 2:56 PM, Takashi Iwai <tiwai@xxxxxxx> wrote:
> Hi,
>
> this is a series of patches for the issue we faced in the firmware
> loader code during debugging the problem with dell_rbu driver with
> 3.9 kernel.
>
> The original problem was that the shutdown gets stuck when DELL BIOS
> update is performed. This turned out to be a problem in the firmware
> loader. Although the reason of dell_rbu driver breakage is still

Sorry, from these patchset, I can't see why it is a problem in firmware.

> unclear, we should fix the firmware loader side, at least, not to
> stall during shutdown.

Firstly you need to describe what/why is the stall? In fact, firmware
loading can't stall forever and it will timeout, but the current 60sec
timeout might be too long.

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/