Re: [PATCH 2/3] firmware: Avoid deadlock of usermodehelper lock at shutdown

[Ming Lei]

On Wed, May 8, 2013 at 2:56 PM, Takashi Iwai <tiwai@xxxxxxx> wrote:
> When a system goes to reboot/shutdown, it tries to disable the
> usermode helper via usermodehelper_disable().  This might be blocked
> when a driver tries to load a firmware beforehand and it's stuck by
> some reason.

IMO, it is better to find why the loading is stuck. Also we already provides
the timeout sysfs file to help to deal with the situation.

>
> In this patch, the firmware class driver registers a reboot notifier
> so that it can abort all pending f/w bufs.  Also enable a flag for
> avoiding the call of usermodehelper after the reboot/shutdown starts.

With this patch, maybe we only hide the real problem.

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/