Re: [PATCH v2] thermal: cpu_cooling: fix stub function

From: Arnd Bergmann
Date: Wed May 08 2013 - 08:12:26 EST


On Thursday 02 May 2013, Eduardo Valentin wrote:
> Rui, Arnd,
>
> On 02-05-2013 12:29, Arnd Bergmann wrote:
> > The function stub for cpufreq_cooling_get_level introduced
> > in 57df81069 "Thermal: exynos: fix cooling state translation"
> > is not syntactically correct C and needs to be fixed to avoid
> > this error:
> >
> > In file included from drivers/thermal/db8500_thermal.c:20:0:
> > include/linux/cpu_cooling.h: In function 'cpufreq_cooling_get_level':
> > include/linux/cpu_cooling.h:57:1:
> > error: parameter name omitted unsigned long cpufreq_cooling_get_level(unsigned int, unsigned int) ^
> > include/linux/cpu_cooling.h:57:1: error: parameter name omitted
> >
> > Cc: Eduardo Valentin <eduardo.valentin@xxxxxx>
> > Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> > Cc: Amit Daniel kachhap <amit.daniel@xxxxxxxxxxx>
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Acked-by: Eduardo Valentin <eduardo.valentin@xxxxxx>

Rui,

Could you please merge that into your thermal/next tree? Right now,
linux-next fails to build because of this, and you probably don't
want to send the current version to Linus without fixing it.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/