Re: [PATCH 4/6] ASoC: ux500: Update tx tdm slots configuration

From: Mark Brown
Date: Wed May 08 2013 - 07:02:13 EST


On Wed, May 08, 2013 at 09:14:19AM +0200, Fabio Baltieri wrote:
> Update ab8500-codec and mop500_ab8500 tx slot configuration to reflect
> the actual one used by STE. Also update a wrong comment in the process.

This seems wrong, the individual chip drivers should just be doing
whatever they're being told by the machine driver. Sounds like there's
two fixes needed here - one is to change the TDM API so that the chip
drivers are just implementing configuration supplied by the machine
driver and the other is to change the configuration being done to
whatever is desired.

Attachment: signature.asc
Description: Digital signature