Re: [PATCH] Staging: Panel: panel: Fixed checkpatch line lengthwarnings

From: Dan Carpenter
Date: Sun May 05 2013 - 09:07:38 EST


On Sat, May 04, 2013 at 11:21:17AM -0400, Jake Champlin wrote:
> @@ -1802,10 +1803,11 @@ static inline void input_state_falling(struct logical_input *input)
>
> if (input->u.kbd.repeat_str[0]) {
> char *repeat_str = input->u.kbd.repeat_str;
> - if (input->high_timer >= KEYPAD_REP_START)
> + if (input->high_timer >= KEYPAD_REP_START) {
> + int s = sizeof(input->u.kbd.repeat_str);
> input->high_timer -= KEYPAD_REP_DELAY;
> - keypad_send_key(repeat_str,
> - sizeof(input->u.kbd.repeat_str));
> + keypad_send_key(repeat_str, s);
> + }


This looks like a bugfix. Good job. Please mention bug fixes in
the changelog next time.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/