Re: [PATCH -tip 1/4] sched: Avoid cputime scaling overflow

From: Ingo Molnar
Date: Tue Apr 30 2013 - 07:11:27 EST



* Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote:

> Here is patch, which add Linus cputime scaling algorithm to the kernel.
>
> This is follow up of commit d9a3c9823a2e6a543eb7807fb3d15d8233817ec5
> "sched: Lower chances of cputime scaling overflow" which try to avoid
> multiplication overflow, but not guarantee that the overflow will not
> happen.
>
> Linus crated different algorithm, which avoid completely multiplication
> overflow by dropping precision when numbers are big. It was tested
> by me and it gives good relative error of scaled numbers.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>

For multi-authored code it's generally nice to add a tag like this:

Originally-From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

It would also be nice to quote the testing results/output and the
precision estimations in the changelog - so that others can see the code's
current capabilities and limitations.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/