Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: usedevm_gpio_request_one()

[Guenter Roeck]

On Tue, Apr 30, 2013 at 10:54:03AM +0900, Jingoo Han wrote:
> On Tuesday, April 30, 2013 1:44 AM, Guenter Roeck wrote:
> > On Mon, Apr 29, 2013 at 06:30:43PM +0900, Jingoo Han wrote:
> > > Use devm_gpio_request_one() to make cleanup paths simpler.
> > >
> > > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> > 
> > This patch also addresses the missing gpio_free in the probe error path
> > (if the call to misc_register() fails).
> 
> When devm_gpio_request_one() is used, there is no need to call
> devm_gpio_free().
> 
> It is because, these resource managed functions such as
> devm_gpio_request_one() allow the driver core to automatically
> clean up any allocation, when probe function fails.
> 
I am well aware of this.

I said this patch _addresses_ a problem, not that it creates one.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/