Re: [PATCH] media: i2c: adv7343: add OF support

[Prabhakar Lad]

Hi Laurent,

Thanks for the review.

On Mon, Apr 29, 2013 at 7:32 PM, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Friday 26 April 2013 18:48:06 Prabhakar Lad wrote:
>> From: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
>>
>> add OF support for the adv7343 driver.
>>
>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
>> Cc: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
>> Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
>> Cc: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
>> Cc: Sakari Ailus <sakari.ailus@xxxxxx>
>> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
>> Cc: Rob Herring <rob.herring@xxxxxxxxxxx>
>> Cc: Rob Landley <rob@xxxxxxxxxxx>
>> Cc: devicetree-discuss@xxxxxxxxxxxxxxxx
>> Cc: linux-doc@xxxxxxxxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> Cc: davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx
>> ---
>>  .../devicetree/bindings/media/i2c/adv7343.txt      |   69 +++++++++++++++++
>>  drivers/media/i2c/adv7343.c                        |   75 ++++++++++++++++-
>>  2 files changed, 142 insertions(+), 2 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/media/i2c/adv7343.txt
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/adv7343.txt
>> b/Documentation/devicetree/bindings/media/i2c/adv7343.txt new file mode
>> 100644
>> index 0000000..8426f8d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/i2c/adv7343.txt
>> @@ -0,0 +1,69 @@
>> +* Analog Devices adv7343 video encoder
>> +
>> +The ADV7343 are high speed, digital-to-analog video encoders in a 64-lead
>> LQFP +package. Six high speed, 3.3 V, 11-bit video DACs provide support for
>> composite +(CVBS), S-Video (Y-C), and component (YPrPb/RGB) analog outputs
>> in standard +definition (SD), enhanced definition (ED), or high definition
>> (HD) video +formats.
>> +
>> +The ADV7343 have a 24-bit pixel input port that can be configured in a
>> variety +of ways. SD video formats are supported over an SDR interface, and
>> ED/HD video +formats are supported over SDR and DDR interfaces. Pixel data
>> can be supplied +in either the YCrCb or RGB color spaces.
>> +
>> +Required Properties :
>> +- compatible: Must be "ad,adv7343-encoder"
>> +
>> +Optional Properties :
>> +- ad-adv7343-power-mode-sleep-mode: on enable the current consumption is
>> +                                    reduced to micro ampere level. All DACs
>> +                                    and the internal PLL circuit are
>> +                                    disabled.
>> +- ad-adv7343-power-mode-pll-ctrl: PLL and oversampling control. This
>> +                                  control allows internal PLL 1 circuit to
>> +                                  be powered down and the oversampling to
>> +                                  be switched off.
>> +
>> +- ad-adv7343-power-mode-dac-1: power on/off DAC 1.
>> +- ad-adv7343-power-mode-dac-2: power on/off DAC 2.
>> +- ad-adv7343-power-mode-dac-3: power on/off DAC 3.
>> +- ad-adv7343-power-mode-dac-4: power on/off DAC 4.
>> +- ad-adv7343-power-mode-dac-5: power on/off DAC 5.
>> +- ad-adv7343-power-mode-dac-6: power on/off DAC 6.
>> +- ad-adv7343-sd-config-dac-out-1: Configure SD DAC Output 1.
>> +- ad-adv7343-sd-config-dac-out-2: Configure SD DAC Output 2.
>
> s/ad-/ad,/
>
OK

> Do all those properties really need to be specified at the endpoint level
> instead of the device node level ?
>
Yes.

> I'll let Hans comment on the individual properties, he knows more than I do
> about DACs.
>
>> +Example:
>> +
>> +i2c0@1c22000 {
>> +     ...
>> +     ...
>> +
>> +     adv7343@2a {
>> +             compatible = "ad,adv7343-encoder";
>> +             reg = <0x2a>;
>> +
>> +             port {
>> +                     adv7343_1: endpoint {
>> +                                     /* Active high (Defaults to false) */
>
> Active high ?
>
:-) will fix it.

Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/