[PATCH] exofsï don't increase urilen if krealloc() fails

[Zhao Hongjiang]

Without the patch, edp->urilen is increased before krealloc(). If krealloc() fails,
edp->urilen is too high. Fix that by only updating edp->urilen if krealloc() is successful.

Signed-off-by: Zhao Hongjiang <zhaohongjiang@xxxxxxxxxx>
---
 fs/exofs/sys.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/exofs/sys.c b/fs/exofs/sys.c
index 1b4f2f9..79b0a85 100644
--- a/fs/exofs/sys.c
+++ b/fs/exofs/sys.c
@@ -82,11 +82,11 @@ static ssize_t uri_store(struct exofs_dev *edp, const char *buf, size_t len)
 {
 	uint8_t *new_uri;
 
-	edp->urilen = strlen(buf) + 1;
-	new_uri = krealloc(edp->uri, edp->urilen, GFP_KERNEL);
+	new_uri = krealloc(edp->uri, strlen(buf) + 1, GFP_KERNEL);
 	if (new_uri == NULL)
 		return -ENOMEM;
 	edp->uri = new_uri;
+	edp->urilen = strlen(buf) + 1;
 	strncpy(edp->uri, buf, edp->urilen);
 	return edp->urilen;
 }
-- 1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/