Re: [PATCH] ACPI thermal: do not always returnTHERMAL_TREND_RAISING for active trip points

[Zhang Rui]

On Sat, 2013-04-27 at 12:23 +0200, Pavel Machek wrote:
> Hi!
> 
> > Commit 4ae46befb49d4173122e0afa995c4e93d01948a2
> > introduces a regression that the fan is always on
> > even if the system is in idle state.
> > 
> > My original idea in that commit is that:
> > when the current temperature is above the trip point,
> > keep the fan on, even if the temperature is dropping.
> > when the current temperature is below the trip point,
> > turn on the fan when the temperature is raising,
> > turn off the fan when the temperature is dropping.
> 
> Is that even right algoritm?
> 
sorry the changelog is not clear enough here.
I should say,
"keep the fan on when the temperature is raising"
"turn off the fan when the temperature is dropping"

> Assume I'm running at very cold room, lets say -10C. Assume idle CPU
> will hover around 30C with no fan, or hover around 10C with fan
> running, trip point being 50C.
> 
> You _could_ leave fan off until 50C, having silent, passively cooled
> system.
> 
> What it will do instead is annoyingly pulse fan at 10C.
> 
First, fan will never spins on if the temperature never hits 50C.

let's see how ACPI 3.0 fan (just have on and off state) is supposed to
work after overheat.
1. temperature goes above 50C
2. Fan starts to spin.
3. a) if temperature goes higher (if possible), fan keeps on.
   b) if temperature drops, but still above 50C. the fan keeps on.
   c) if temperature drops below 50C, the last temperature is above 50C,
thus the fan is turned off.
   d) if the temperature goes higher again, the fan will not spin on
until the temperature is higher than the trip point (50C) again.

is this behavior what you want?

Thanks,
rui

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/