Re: [PATCH -next] ipc: make refcounter atomic (was Re: linux-next:Tree for Apr 23 [ Call-Traces: lib/debugobjects.c | kernel/rcupdate.c |kernel/rcutree.c ])

From: Emmanuel Benisty
Date: Thu Apr 25 2013 - 09:14:51 EST


On Thu, Apr 25, 2013 at 7:56 PM, Rik van Riel <riel@xxxxxxxxxxx> wrote:
> On 04/24/2013 07:05 PM, Sedat Dilek wrote:
>>
>> On Thu, Apr 25, 2013 at 12:16 AM, Davidlohr Bueso
>> <davidlohr.bueso@xxxxxx> wrote:
>
>
>>> This patch converts the IPC RCU header's reference counter to atomic_t.
>>> The return of
>>> ipc_rcu_getref() is modified to inform the callers if it actually
>>> succeeded.
>>>
>>> Now all callers return -EIDRM upon failure and abort the current
>>> operation. Two exceptions are
>>> in semaphore code where sem_getref_and_unlock() and sem_getref() trigger
>>> a warning but proceed
>>> to freeing up any held locks.
>>>
>>> Signed-off-by: Davidlohr Bueso <davidlohr.bueso@xxxxxx>
>>> Suggested-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>>> CC: Rik van Riel <riel@xxxxxxxxxxx>
>>> CC: Paul McKenney <paul.mckenney@xxxxxxxxxx>
>>> CC: Sedat Dilek <sedat.dilek@xxxxxxxxx>
>>> CC: Emmanuel Benisty <benisty.e@xxxxxxxxx>
>>> CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>>
>>
>> Missing my Reported-by ...!
>
>
>> ...so please add also my Tested-by!
>
>
> And my ax!
>
> I mean ... Reviewed-by: Rik van Riel <riel@xxxxxxxxxx>

FWIW, my machine survived building chromium with this patch instead of Linus'.

Thanks.
-- Emmanuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/