Re: [PATCH 05/14] perf tools: Introduce new 'ftrace' tool

[Namhyung Kim]

On Wed, 24 Apr 2013 16:09:18 +0200, Jiri Olsa wrote:
> On Tue, Apr 23, 2013 at 05:31:03PM +0900, Namhyung Kim wrote:
>> From: Namhyung Kim <namhyung.kim@xxxxxxx>
>> +out:
>> +	put_tracing_file(file);
>> +	return ret;
>> +}
>> +
>> +static int reset_tracing_files(struct perf_ftrace *ftrace __maybe_unused)
>> +{
>> +	if (write_tracing_file("tracing_on", "0") < 0)
>> +		return -1;
>> +
>> +	if (write_tracing_file("current_tracer", "nop") < 0)
>> +		return -1;
>> +
>> +	if (write_tracing_file("set_ftrace_pid", " ") < 0)
>> +		return -1;
>
> I think we want to reset set_ftrace_pid file as well
> probably to -1..
>
> if I'm tracing command with this file having wrong CPU(s)
> I dont get any data..

Not sure I understood what you mean exactly.

Do you mean it should be changed to

	if (write_tracing_file("set_ftrace_pid", "-1") < 0)

?  It seems it's the right thing to do for compatibility.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/