Re: [PATCH v2] efi: Check EFI revision in setup_efi_vars

From: Matt Fleming
Date: Wed Apr 24 2013 - 11:20:15 EST


On 24/04/13 16:16, Josh Boyer wrote:
> We need to check the runtime sys_table for the EFI version the firmware
> specifies instead of just checking for a NULL QueryVariableInfo. Older
> implementations of EFI don't have QueryVariableInfo but the runtime is
> a smaller structure, so the pointer to it may be pointing off into garbage.
>
> This is apparently the case with several Apple firmwares that support EFI
> 1.10, and the current check causes them to no longer boot. Fix based on
> a suggestion from Matthew Garrett.
>
> Signed-off-by: Josh Boyer <jwboyer@xxxxxxxxxx>
> ---
> v2: Drop the unnecessary NULL check
>
> arch/x86/boot/compressed/eboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/