Re: [PATCH -next v2] gpu: host1x: gr2d: fix error return code ingr2d_submit()

From: Thierry Reding
Date: Wed Apr 24 2013 - 02:44:17 EST


On Wed, Apr 24, 2013 at 10:44:08AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> Fix to return -EINVAL in the host1x_bo lookup error handling
> case instead of 0, as done elsewhere in this function.

So with my comment to v1 addressed this becomes invalid again. I think
in both cases using -ENOENT is a better choice. Pretty much any instance
where drm_gem_object_lookup() fails is handled by returning -ENOENT, so
we should do the same in this driver for consistency.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature