Re: [RFC PATCH 0/2] sched: move content out of core files for load average

From: Rakib Mullick
Date: Sat Apr 13 2013 - 00:30:19 EST


On Sat, Apr 13, 2013 at 6:04 AM, Paul Gortmaker
<paul.gortmaker@xxxxxxxxxxxxx> wrote:
> Recent activity has had a focus on moving functionally related blocks of stuff
> out of sched/core.c into stand-alone files. The code relating to load average
> calculations has grown significantly enough recently to warrant placing it in
> a separate file.
>
> Here we do that, and in doing so, we shed ~20k of code from sched/core.c (~10%).
>
> A couple small static functions in the core sched.h header were also localized
> to their singular user in sched/fair.c at the same time, with the goal to also
> reduce the amount of "broadcast" content in that sched.h file.
>
> Paul.
> ---
>
> [ Patches sent here are tested on tip's sched/core, i.e. v3.9-rc1-38-gb329fd5
>
> Assuming that this change is OK with folks, the timing can be whatever is most
> convenient -- i.e. I can update/respin it close to the end of the merge window
> for what will be v3.10-rc1, if that is what minimizes the inconvenience to folks
> who might be changing the code that is relocated here. ]
>
> Paul Gortmaker (2):
> sched: fork load calculation code from sched/core --> sched/load_avg
> sched: move update_load_[add/sub/set] from sched.h to fair.c
>
> kernel/sched/Makefile | 2 +-
> kernel/sched/core.c | 569 -----------------------------------------------
> kernel/sched/fair.c | 18 ++
> kernel/sched/load_avg.c | 577 ++++++++++++++++++++++++++++++++++++++++++++++++
> kernel/sched/sched.h | 26 +--
> 5 files changed, 604 insertions(+), 588 deletions(-)
> create mode 100644 kernel/sched/load_avg.c
>

Is there any impact positive over vmlinuz size after these changes?

Thanks,
Rakib
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/