Re: [PATCH 3/4] gpio: Kontron PLD gpio driver

From: Linus Walleij
Date: Fri Apr 12 2013 - 18:05:17 EST


On Fri, Apr 12, 2013 at 1:09 PM, Michael Brunner <mibru@xxxxxx> wrote:

>> (...)
>> > +struct kempld_gpio_data {
>> > + struct gpio_chip chip;
>> > + int irq;
>> > + struct kempld_device_data *pld;
>> > + uint16_t mask;
>>
>> Just u16?
>
> The specification allows 16 GPIOs for this device, therefore this seems
> to be the right size. Would it be better to use another type instead?

Ah, I was just asking you to use "u16" instead of "uint16_t".

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/