Re: [PATCH] net: usb: active URB submitted multiple times

From: David Miller
Date: Fri Apr 12 2013 - 15:18:30 EST


From: Petko Manolov <petkan@xxxxxxxxxxxxx>
Date: Thu, 11 Apr 2013 22:00:59 +0300 (EEST)

> From: Petko Manolov <petkan@xxxxxxxxxxxxx>
>
> (For inclusion in 3.10, diff against latest net-next.)
>
> Pegasus driver used single callback for sync and async control URBs.
> Special flags were employed to distinguish between both, but due to flawed
> logic (as Sarah Sharp spotted) it didn't always work. As a result of this
> change [get|set]_registers() are now much simpler. Async write is also
> leaner and does not use single, statically allocated memory for
> usb_ctrlrequest, which is another potential race when asynchronously
> submitting URBs.
>
> The socket buffer pool for the receive path is now gone. It's existence
> didn't make much difference (performance-wise) and the code is better off
> without the spinlocks protecting it.
>
> Largely duplicated code in routines reading and writing MII registers is
> now packed in __mii_op().
>
> Adding URL for the public pegasus git repository.
>
> Signed-off-by: Petko Manolov <petkan@xxxxxxxxxxxxx>

When submitting a new version of a patch, you must list what
changed from the previous version after the "---" delimiter
rather than having people try and guess.

> +T: git git://petkan@xxxxxxxxxxxxxxx/p/pegasus2/git

There is no way that specifying your GIT login in this URL
meant for public use is correct, or is it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/