Re: [PATCH] nbd: increase default and max request sizes

From: Andrew Morton
Date: Thu Apr 11 2013 - 18:34:23 EST


On Tue, 2 Apr 2013 15:41:20 -0400 (EDT) Paul Clements <paul.clements@xxxxxxxxxxxx> wrote:

> This patch raises the default max request size for nbd to 128KB (from 127KB)
> to get it 4KB aligned. This patch also allows the max request size to be
> increased (via /sys/block/nbd<x>/queue/max_sectors_kb) to 32MB.
>
> The patch makes nbd network traffic more efficient by:
> - reducing request fragmentation (4KB alignment)
> - reducing the number of requests (fewer round trips, less network overhead)
>
> Especially in high latency networks, larger request size can make a dramatic
> difference in performance.
>
> From: Michal Belczyk <belczyk@xxxxxxxxxxxxx>
> Signed-off-by: Paul Clements <paul.clements@xxxxxxxxxxxx>

This is a bit odd.

- The author's "From:" line shouild appear right at the start of the
changelog.

- Michal's Signed-off-by: is absent. Is one available?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/