Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI

From: Peter Hüwe
Date: Thu Apr 11 2013 - 17:41:26 EST


Hi Matthias,
Am Donnerstag, 11. April 2013, 10:58:59 schrieb Mathias LEBLANC:
> Hi Peter,
>
> Yes, you have right, these error are generated by #ifndef
> __STM_ST33_TPM_SPI_H__ Just remove it and the #endif next the structure.
Yes, I know that - for the submission to be included this has to be changed by
you.


> Did you have these warning when you have run checkpatch script?
You mean the sparse warnings I sent you?
I removed the superflous ifdef to compile it and then let sparse run against
it.
The driver passes normal checkpatch check, unless you call it with -strict


Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/