Re: [ 024/171 ] sfc: lock TX queues when callingnetif_device_detach()

From: Steven Rostedt
Date: Thu Apr 11 2013 - 16:57:27 EST


On Thu, 2013-04-11 at 16:54 -0400, Steven Rostedt wrote:
> On Thu, 2013-04-11 at 21:42 +0100, Ben Hutchings wrote:
> > On Thu, 2013-04-11 at 16:25 -0400, Steven Rostedt wrote:
> >
> > > 3.6.11.2 stable review patch.
> > > If anyone has any objections, please let me know.
> > >
> > > ------------------
> > >
> > > From: Daniel Pieczko <dpieczko@xxxxxxxxxxxxxx>
> > >
> > > [ Upstream commit c2f3b8e3a44b6fe9e36704e30157ebe1a88c08b1 ]
> > >
> > > The assertion of netif_device_present() at the top of
> > > efx_hard_start_xmit() may fail if we don't do this.
> >
> > You should also cherry-pick commit 35205b211c8d 'sfc: Disable soft
> > interrupt handling during efx_device_detach_sync()' on top of this.
> >
>
> Hmm, I had that in my quilt queue, but commented it out. I guess it
> didn't apply well, and it was a bit too much to back port blindly. I'll
> take another look.

Strange, it's a trivial patch that applied fine. I wonder why I
commented it out?

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/