Re: [PATCH UPDATED 1/7] x86: don't show trace into stacktracemachinery

[Borislav Petkov]

On Wed, Apr 10, 2013 at 01:10:20PM -0700, Tejun Heo wrote:
> +/* sanity check helper for dump_trace(), see dump_trace_current_frame() */
> +static inline void
> +dump_trace_warn_current_frame(struct task_struct *task, struct pt_regs *regs,
> +			      unsigned long bp)
> +{
> +	if ((!task || task == current) && !regs && !bp)
> +		printk(KERN_WARNING "dump_trace: %pf didn't specify neither frame nor regs for %%current\n",

This is double negation and is generally wrong in English. I think you
want to say:

"%pf specified neither frame nor regs for ..."

or

"%pf didn't specify either frame or regs for ..."

Or maybe even passive and shorter:

"%pf: No frame or regs specified for %%current."

and so on.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/