Re: [PATCHv3] driver: serial: prevent UART console idle on suspendwhile using "no_console_suspend"

[Sourav Poddar]

Hi Russell,
On Monday 08 April 2013 10:44 PM, Russell King - ARM Linux wrote:
> On Fri, Apr 05, 2013 at 06:45:33PM +0530, Sourav Poddar wrote:
> > With dt boot, uart wakeup after suspend is non functional while using
> > "no_console_suspend" in the bootargs. With "no_console_suspend" used, we
> > should prevent the runtime suspend of the uart port which is getting used
> > as an console.
> >
> > Cc: Santosh Shilimkar<santosh.shilimkar@xxxxxx>
> > Cc: Felipe Balbi<balbi@xxxxxx>
> > Cc: Rajendra nayak<rnayak@xxxxxx>
> > Tested on omap5430evm, omap4430sdp.
> >
> > Signed-off-by: Sourav Poddar<sourav.poddar@xxxxxx>
> > ---
> > v2->v3
> > Based on Kevin Hilman and Santosh Shilimkar comments, modified
> > serial core/driver layer to bypass runtime suspend
> > for console uart while using "no_console_suspend".
> >
> > This patch is based on Santosh Shilimkar serial patch[1]
> Rather than introducing this "port_is_console" thing, please move
> uart_console() into the serial_core.h header file, making it an inline
> function, and use that in omap-serial.c.
>
> Remember to fix drivers/tty/serial/mpc52xx_uart.c as well for that change.
Thanks for the pointer. Will take care of your suggestions
in the next version.

~Sourav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/